Page MenuHomePhabricator

Avoid bashisms and switch to /bin/sh
ClosedPublic

Authored by emaste on Oct 7 2014, 12:43 PM.

Details

Summary

Bash may not be installed on FreeBSD. Apply minor changes to make this script work with /bin/sh:

  • [ ] and = in tests instead of [[ ]] and ==
  • Manually expand {a,b} brace lists

I was a little surprised to find brace expansion is not POSIX.

A related bash-to-sh change is in http://reviews.llvm.org/D5631

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 14527.Oct 7 2014, 12:43 PM
emaste retitled this revision from to Avoid bashisms and switch to /bin/sh.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a subscriber: Unknown Object (MLST).
emaste added inline comments.
lib/sanitizer_common/scripts/check_lint.sh
102–103 ↗(On Diff #14527)

For some reason there's no & on this run_lint invocation - is that just an oversight?

samsonov accepted this revision.Oct 7 2014, 1:27 PM
samsonov added a reviewer: samsonov.
samsonov added a subscriber: samsonov.

LGTM

lib/sanitizer_common/scripts/check_lint.sh
102–103 ↗(On Diff #14527)

Yes, please add & here.

This revision is now accepted and ready to land.Oct 7 2014, 1:27 PM
emaste closed this revision.Oct 7 2014, 1:34 PM
emaste updated this revision to Diff 14528.

Closed by commit rL219231 (authored by @emaste).