This is a follow-up to r207670 (ELF) and r218636 (COFF).
Details
Diff Detail
Event Timeline
test/MC/MachO/variable-exprs.s | ||
---|---|---|
208 | This is the only part where I'm not sure what's going on :/ |
LGTM
lib/MC/StringTableBuilder.cpp | ||
---|---|---|
72 | Would it make sense to have an else clause that asserted the kind was ELF? Maybe use a fully covered switch? My thinking is that it would make it easier to catch potential bugs if we ever added a new object file format. | |
test/MC/MachO/variable-exprs.s | ||
208 | Obligatory arcane Mach-O infodump:
d2 is defined to be the same as d. d has a n_strx of 7. This means that d2 should have an n_value of 7 as well. |
Would it make sense to have an else clause that asserted the kind was ELF? Maybe use a fully covered switch? My thinking is that it would make it easier to catch potential bugs if we ever added a new object file format.