Page MenuHomePhabricator

[Basic] Extend DiagnosticEngine to store and format Qualifiers

Authored by Anastasia on Jan 2 2019, 3:35 AM.

Diff Detail

Event Timeline

Anastasia created this revision.Jan 2 2019, 3:35 AM
rjmccall added inline comments.Jan 2 2019, 8:51 AM

Unpaired apostrophe, here and below.


The line break is no longer necessary.


Hmm. I think '' is acceptable for the unqualified case in this diagnostic because at least one of the operands has to be non-empty, but it might be better overall to say something like unqualified (not in quotes, of course).

I like the general effect of this, though; this is definitely a more readable diagnostic in the complex cases than it used to be.

Anastasia updated this revision to Diff 179887.Jan 2 2019, 10:32 AM

Addressed review comments.

Anastasia marked 3 inline comments as done.Jan 2 2019, 10:33 AM
rjmccall accepted this revision.Jan 2 2019, 11:20 AM

Thanks, LGTM.

This revision is now accepted and ready to land.Jan 2 2019, 11:20 AM
This revision was automatically updated to reflect the committed changes.