Add support for Visual Studio 2019 and handle Just My Code in the Visual Studio Integration

[sylveon]

Summary

This adds support simply by bumping the excluding maximum revision. It also checks for Just My Code and errors when it is enabled, as well as turns it off by default. It was tested by building this project I contribute to using the addon https://github.com/TranslucentTB/TranslucentTB/tree/develop on Visual Studio 2019.

[sylveon]

VS now has it's own Clang integration, this is not needed anymore.

tools/msbuild/LLVM.Cpp.Common.props

<ClCompile>
       <!-- Set this to "Default" (which means not passing any /RTC option) so that any other value will
            be treated as having been overridden by the user.  This Serves as a hint to the user that
            Default is the value we support, and other values will generate a warning.  It also means
            that if the user simply creates a new project in MSVC (which uses /RTCu by default), then
            switches the toolset to Clang, we will still treat the value as default (which for us is to
            not pass the option).  Only if the user explicitly overrode this setting in a project to use
            /RTCu would we see the warning. -->
       <BasicRuntimeChecks>Default</BasicRuntimeChecks>
+      <!-- Clang does not supports Just My Code debugging but it is enabled by default. -->
+      <SupportJustMyCode>false</SupportJustMyCode>
     </ClCompile>
   </ItemDefinitionGroup>
 </Project>

tools/msbuild/LLVM.Cpp.Common.targets

<Error Condition="'%(ClCompile.OpenMPSupport)' == 'true'"
            File="@(ClCompile)(0,0)"
            Text="clang-cl does not support OpenMP (/openmp).  This file cannot be compiled."/>
 
     <!-- Error if C++ Modules are enabled.  Clang has its own notion of modules that are not compatible. -->
     <Error Condition="'%(ClCompile.EnableModules)' == 'true'"
            File="@(ClCompile)(0,0)"
            Text="clang-cl does not support MSVC Modules (/experimental:module).  This file cannot be compiled."/>
 
+    <!-- Error if Just My Code debugging is enabled. -->
+    <Error Condition="'%(ClCompile.SupportJustMyCode)' == 'true'"
+           File="@(ClCompile)(0,0)"
+           Text="clang-cl does not support Just My Code debugging (/JMC).  This file cannot be compiled."/>
+
     <ItemGroup>
       <ClCompile>
         <!-- Map /ZI and /Zi to /Z7.  Clang internally does this, so if we were
              to just pass the option through, clang would work.  The problem is
              that MSBuild would not.  MSBuild detects /ZI and /Zi and then
              assumes (rightly) that there will be a compiler-generated PDB (e.g.
              vc141.pdb).  Since clang-cl will not emit this, MSBuild will always
              think that the compiler-generated PDB needs to be re-generated from

tools/msbuild/source.extension.vsixmanifest

 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
     <Metadata>
         <Identity Id="llvm.d29c51f0-961f-4e20-aad6-356af569907f" Version="1.0.340780" Language="en-US" Publisher="LLVM Extensions" />
         <DisplayName>LLVM Compiler Toolchain</DisplayName>
         <Description xml:space="preserve">Allows the LLVM Compiler Toolchain (installed separately) to be used from within Visual Studio to build C/C++ Projects.</Description>
         <License>license.txt</License>
     </Metadata>
     <Installation AllUsers="true">
-        <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0,16.0)" />
-        <InstallationTarget Version="[15.0,16.0)" Id="Microsoft.VisualStudio.Pro" />
-        <InstallationTarget Version="[15.0,16.0)" Id="Microsoft.VisualStudio.Enterprise" />
+        <InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[15.0,17.0)" />
+        <InstallationTarget Version="[15.0,17.0)" Id="Microsoft.VisualStudio.Pro" />
+        <InstallationTarget Version="[15.0,17.0)" Id="Microsoft.VisualStudio.Enterprise" />
     </Installation>
     <Dependencies>
         <Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.5,)" />
     </Dependencies>
     <Prerequisites>
-        <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,16.0)" DisplayName="Visual Studio core editor" />
-        <Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core" Version="[15.0.26621.2,16.0)" DisplayName="Visual C++ core desktop features" />
-        <Prerequisite Id="Microsoft.VisualStudio.Component.VC.CoreIde" Version="[15.0.26606.0,16.0)" DisplayName="Visual Studio C++ core features" />
+        <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,17.0)" DisplayName="Visual Studio core editor" />
+        <Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core" Version="[15.0.26621.2,17.0)" DisplayName="Visual C++ core desktop features" />
+        <Prerequisite Id="Microsoft.VisualStudio.Component.VC.CoreIde" Version="[15.0.26606.0,17.0)" DisplayName="Visual Studio C++ core features" />
     </Prerequisites>
 </PackageManifest>