Page MenuHomePhabricator

[libc++] Fix _LIBCPP_EXPORTED_FROM_ABI when visibility annotations are disabled
ClosedPublic

Authored by thomasanderson on Dec 13 2018, 11:55 AM.

Details

Summary

Fixes a bug where functions would get exported when building with
-fvisibility=hidden and defining _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS. No
visibility annotations should be added in this case.

The new logic for _LIBCPP_EXPORTED_FROM_ABI matches that of the other visibility
annotations around it.

Diff Detail

Repository
rCXX libc++

Event Timeline

EricWF accepted this revision.Dec 13 2018, 12:06 PM
EricWF added a reviewer: ldionne.
EricWF added a subscriber: ldionne.

Adding @ldionne for visibility.

Otherwise, this LGTM. Feel free to commit it.

This revision is now accepted and ready to land.Dec 13 2018, 12:06 PM
thomasanderson edited the summary of this revision. (Show Details)Dec 13 2018, 12:08 PM
This revision was automatically updated to reflect the committed changes.

I'm late in the game, but the fix is obviously correct. Thanks.