This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Add lowering of i128 numbers as struct fields
ClosedPublic

Authored by denzp on Nov 30 2018, 1:21 PM.

Details

Summary

Addition to D34555 - override VTs computation with ComputePTXValueVTs for struct fields.

Diff Detail

Repository
rL LLVM

Event Timeline

denzp created this revision.Nov 30 2018, 1:21 PM
denzp retitled this revision from Add lowering of i128 numbers as struct fields to [NVPTX] Add lowering of i128 numbers as struct fields.Nov 30 2018, 1:31 PM
tra accepted this revision.Nov 30 2018, 1:41 PM
tra added inline comments.
lib/Target/NVPTX/NVPTXISelLowering.cpp
186–188 ↗(On Diff #176188)

for(auto const *EI : STy->elements()) ?

This revision is now accepted and ready to land.Nov 30 2018, 1:41 PM
denzp updated this revision to Diff 176201.Nov 30 2018, 1:59 PM

@tra thanks for the review! If it looks good now, could you please commit it?

denzp marked an inline comment as done.Nov 30 2018, 2:01 PM

We still need to know the current element index, so there is an outer "counter". Anyway, the code looks more readable now!

This revision was automatically updated to reflect the committed changes.
tra added a comment.Apr 7 2021, 12:33 PM

@denzp: FYI. Apparently we still can't handle [1 x i128]

https://bugs.llvm.org/show_bug.cgi?id=49877

Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 12:33 PM