Moved PlatformDarwin::GetEnvironment() to PlatformPOSIX

[sbest]

Summary

I was tracking a problem where llgs on linux would not pick up any environment variables. On OSX there is a virtual function PlatformDarwin::GetEnvironment() which correctly sets up the list of environment variables. On linux llgs it defaults to a base class default implementation which clears the list.

I moved the OSX implementation down to PlatformPOSIX. This fixes my problem on linux still works properly on OSX.

[clayborg]

Looks good.

[tfiala]

Thanks, Greg. I'll get this checked in.

There is a lot more motion of PlatformDarwin into PlatformPOSIX in our
work-in-progress branch here:
https://github.com/tfiala/lldb/tree/dev-llgs-local-launch

This one was self-contained enough to push up.

[tfiala]

svn commit
Sending source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Sending source/Plugins/Platform/MacOSX/PlatformDarwin.h
Sending source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
Sending source/Plugins/Platform/POSIX/PlatformPOSIX.h
Transmitting file data ....
Committed revision 218424.

source/Plugins/Platform/MacOSX/PlatformDarwin.h

     virtual bool
     ModuleIsExcludedForNonModuleSpecificSearches (lldb_private::Target &target, const lldb::ModuleSP &module_sp);
     
-    virtual size_t
-    GetEnvironment (lldb_private::StringList &environment);
-
     bool
     ARMGetSupportedArchitectureAtIndex (uint32_t idx, lldb_private::ArchSpec &arch);
     

source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

     return bp_sp;
 }
 
-size_t
-PlatformDarwin::GetEnvironment (StringList &env)
-{
-    if (IsRemote())
-    {
-        if (m_remote_platform_sp)
-            return m_remote_platform_sp->GetEnvironment(env);
-        return 0;
-    }
-    return Host::GetEnvironment(env);
-}
 
 int32_t
 PlatformDarwin::GetResumeCountForLaunchInfo (ProcessLaunchInfo &launch_info)

source/Plugins/Platform/POSIX/PlatformPOSIX.h

     lldb_private::ArchSpec
     GetRemoteSystemArchitecture () override;
 
+    virtual size_t
+    GetEnvironment (lldb_private::StringList &environment);
+
     bool
     IsConnected () const override;
 

source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

     return false;
 }
 
+size_t
+PlatformPOSIX::GetEnvironment (StringList &env)
+{
+    if (IsRemote())
+    {
+        if (m_remote_platform_sp)
+            return m_remote_platform_sp->GetEnvironment(env);
+        return 0;
+    }
+    return Host::GetEnvironment(env);
+}
+
 bool
 PlatformPOSIX::GetRemoteOSKernelDescription (std::string &s)
 {