Page MenuHomePhabricator

Moved PlatformDarwin::GetEnvironment() to PlatformPOSIX
ClosedPublic

Authored by sbest on Sep 24 2014, 3:58 PM.

Details

Reviewers
clayborg
tfiala
Summary

I was tracking a problem where llgs on linux would not pick up any environment variables. On OSX there is a virtual function PlatformDarwin::GetEnvironment() which correctly sets up the list of environment variables. On linux llgs it defaults to a base class default implementation which clears the list.

I moved the OSX implementation down to PlatformPOSIX. This fixes my problem on linux still works properly on OSX.

Diff Detail

Event Timeline

sbest updated this revision to Diff 14055.Sep 24 2014, 3:58 PM
sbest retitled this revision from to Moved PlatformDarwin::GetEnvironment() to PlatformPOSIX.
sbest updated this object.
sbest edited the test plan for this revision. (Show Details)
sbest added reviewers: tfiala, clayborg.
sbest added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Sep 24 2014, 4:01 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 24 2014, 4:01 PM
tfiala edited edge metadata.Sep 24 2014, 4:09 PM

Thanks, Greg. I'll get this checked in.

There is a lot more motion of PlatformDarwin into PlatformPOSIX in our
work-in-progress branch here:
https://github.com/tfiala/lldb/tree/dev-llgs-local-launch

This one was self-contained enough to push up.

tfiala accepted this revision.Sep 24 2014, 4:20 PM
tfiala closed this revision.
tfiala edited edge metadata.

svn commit
Sending source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Sending source/Plugins/Platform/MacOSX/PlatformDarwin.h
Sending source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
Sending source/Plugins/Platform/POSIX/PlatformPOSIX.h
Transmitting file data ....
Committed revision 218424.