Page MenuHomePhabricator

[WIP][DebugInfo] Use VReg users to find DBG_VALUEs for a value
AbandonedPublic

Authored by jmorse on Nov 19 2018, 11:55 AM.

Details

Reviewers
None
Summary

This is a work-in-progress related to PR38754 [0], uploaded for visibility rather than review.

This patch is ugly because the behaviour exposed by the patch is ugly. If you disable placeDbgValues (topic of [0]), the currently semi-legitimate assumption of collectDebugValues (that DBG_VALUEs always follow the values definition) is eliminated, meaning DBG_VALUEs of a vreg can be in any BB in the function.

On the whole this is what we want IMHO, because that might be the debug-model of the program. However, we get a crash in MachineSink if it tries to sink a DBG_VALUE in front of the value-definition (maybe an un-related use-before-def bug), and a variety of infinite loops if DBG_VALUEs are sunk out of other BBs.

These are all matters that can be considered and fixed, they've just never been problems because placeDbgValues has squashed any kind of complicated DBG_VALUE layout. I've uploaded this patch because it allows clang/llvm to compile itself, might be a starting point for making other improvements. I've also only tested it with D54716 reducing the amount of code that uses collectDebugValues.

[0] https://bugs.llvm.org/show_bug.cgi?id=38754

Diff Detail

Event Timeline

jmorse created this revision.Nov 19 2018, 11:55 AM
jmorse abandoned this revision.Jan 16 2019, 7:55 AM

This was superseded by... well... trying to kill off collectDebugValues, basically. It's a general function that gets used in very specialised circumstances.