Page MenuHomePhabricator

Remove unused getMDNodeFwdRefOrNull interfaces (NFC)
ClosedPublic

Authored by tejohnson on Nov 14 2018, 1:53 PM.

Details

Summary

Followup from D53596/r346891. Remove the getMDNodeFwdRefOrNull interface
to the MDLoader since it is no longer used. Also improve error messages
when the internal implementation is used within the MDLoader.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Nov 14 2018, 1:53 PM

@steven_wu I realized there are still some uses of the internal getMDNodeFwdRefOrNull implementation, so just removed the external interfaces. It seemed like switching to returning ErrorOr<MDNode*> actually made things more complicated, so I just tried to improve the existing error messages. Let me know if you have something else in mind.

steven_wu accepted this revision.Nov 14 2018, 1:54 PM

Thanks!

This revision is now accepted and ready to land.Nov 14 2018, 1:54 PM
This revision was automatically updated to reflect the committed changes.