Page MenuHomePhabricator

Fix up the HostThread interface
ClosedPublic

Authored by zturner on Sep 19 2014, 1:51 PM.

Details

Summary
  • Removes GetState / SetState
  • Adds a method IsJoinable()

There is no need for a distinction between IsHandleValid and IsThreadRunning, because even if a thread has run to completion, you are still required to Join on it. So a better function simply checks whether a thread is joinable. This is equivalent to checking if the handle is valid, because the Join() operation can reset the handle to an invalid handle after it has been performed.

Diff Detail

Event Timeline

zturner updated this revision to Diff 13889.Sep 19 2014, 1:51 PM
zturner retitled this revision from to Fix up the HostThread interface.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a subscriber: Unknown Object (MLST).
zturner closed this revision.Sep 23 2014, 11:42 AM
zturner updated this revision to Diff 14005.

Closed by commit rL218325 (authored by @zturner).