Page MenuHomePhabricator

[NFC][LICM] Factor out instruction erasing logic
ClosedPublic

Authored by mkazantsev on Nov 1 2018, 4:52 PM.

Details

Summary

This patch factors out a function that makes all required updates
whenever an instruction gets erased.

Diff Detail

Repository
rL LLVM

Event Timeline

mkazantsev created this revision.Nov 1 2018, 4:52 PM
apilipenko accepted this revision.Nov 1 2018, 5:13 PM

With this change you seem to be invalidating AST for instructions which have not been previously invalidated. I would hesitate to call this NFC.

lib/Transforms/Scalar/LICM.cpp
483–485 ↗(On Diff #172270)

Remove { }

890 ↗(On Diff #172270)

static

This revision is now accepted and ready to land.Nov 1 2018, 5:13 PM
mkazantsev marked 2 inline comments as done.Nov 1 2018, 5:20 PM
This revision was automatically updated to reflect the committed changes.