This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ] Improve isFoldableLoad() for Sub, SDiv and UDiv.
ClosedPublic

Authored by jonpa on Oct 26 2018, 10:03 PM.

Details

Reviewers
uweigand
Summary

Sub, SDiv and UDiv are not commutative, so only the RHS operand can fold a load. It seems there should be a check for this.

Only minor ("mixed") impact on SPEC, it seems:
Sub changed 8 loops / 9 files.
SDiv/UDiv changed 2 loops / 1 file.

Diff Detail

Event Timeline

jonpa created this revision.Oct 26 2018, 10:03 PM
uweigand accepted this revision.Oct 29 2018, 10:00 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 29 2018, 10:00 AM
jonpa closed this revision.Oct 30 2018, 6:44 AM

Thanks for review, committed as r345596.