Page MenuHomePhabricator

Patch for bug 18635
ClosedPublic

Authored by amusman on Sep 15 2014, 5:44 AM.

Details

Summary

Please review small fox for bug 18635 (clang crashes in llvm::Module::getNamedValue on thread_local std::unique_ptr<int>).

Diff Detail

Repository
rL LLVM

Event Timeline

amusman updated this revision to Diff 13704.Sep 15 2014, 5:44 AM
amusman retitled this revision from to Patch for bug 18635 .
amusman updated this object.
amusman edited the test plan for this revision. (Show Details)
amusman added reviewers: rsmith, hfinkel.
amusman added a subscriber: Unknown Object (MLST).
rsmith accepted this revision.Sep 25 2014, 3:13 PM
rsmith edited edge metadata.

Yep, makes sense, LGTM thanks!

Test case could probably be reduced a bit further (the templates don't seem relevant, I think all you need is a struct type where constant emission produces an LLVM type different from the type that we'd naturally produce -- a union might be a more reliable way to create that) and folded into another CodeGen test, but I'm happy with this either way.

This revision is now accepted and ready to land.Sep 25 2014, 3:13 PM
amusman closed this revision.Sep 25 2014, 11:38 PM
amusman updated this revision to Diff 14096.

Closed by commit rL218503 (authored by @amusman).