Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

Authored by BillyONeal on Oct 19 2018, 6:31 PM.



The test is trying to avoid saying aligned_alloc on Windows' UCRT, which does not (and can not) implement aligned_alloc. However, it's testing for c1xx, meaning clang on Windows will fail this test when using the UCRT.

Diff Detail

Event Timeline

BillyONeal created this revision.Oct 19 2018, 6:31 PM

Also fixed cstdlib tests.

EricWF accepted this revision.Oct 19 2018, 8:22 PM

Looks fine to me

This revision is now accepted and ready to land.Oct 19 2018, 8:22 PM
BillyONeal closed this revision.Oct 19 2018, 8:39 PM

Thank you! :D

Committed r344829