This is an archive of the discontinued LLVM Phabricator instance.

Differential D5327

Fix for PR20917: wrong lowering of ctlz with vector arguments
AbandonedPublic

Authored by volkalexey on Sep 12 2014, 1:43 AM.

Download Raw Diff

Details

Reviewers

nadav

Summary

This patch fixes bug in type promotion for ctlz intrinsic.

Diff Detail

Event Timeline

volkalexey updated this revision to Diff 13618.Sep 12 2014, 1:43 AM

volkalexey retitled this revision from to Fix for PR20917: wrong lowering of ctlz with vector arguments.

volkalexey updated this object.

volkalexey edited the test plan for this revision. (Show Details)

volkalexey added a reviewer: nadav.

volkalexey set the repository for this revision to rL LLVM.

volkalexey added a subscriber: zinovy.nis.

volkalexey added a subscriber: Unknown Object (MLST).

Minor test fix.

Fix for bug committed in r217671

Revision Contents

Path

Size

lib/

CodeGen/

SelectionDAG/

LegalizeIntegerTypes.cpp

4 lines

test/

CodeGen/

X86/

pr20917.ll

17 lines

Diff 13620

lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp

Show First 20 Lines • Show All 337 Lines • ▼ Show 20 Lines	SDValue DAGTypeLegalizer::PromoteIntRes_CTLZ(SDNode *N) {
// Zero extend to the promoted type and do the count there.		// Zero extend to the promoted type and do the count there.
SDValue Op = ZExtPromotedInteger(N->getOperand(0));		SDValue Op = ZExtPromotedInteger(N->getOperand(0));
SDLoc dl(N);		SDLoc dl(N);
EVT OVT = N->getValueType(0);		EVT OVT = N->getValueType(0);
EVT NVT = Op.getValueType();		EVT NVT = Op.getValueType();
Op = DAG.getNode(N->getOpcode(), dl, NVT, Op);		Op = DAG.getNode(N->getOpcode(), dl, NVT, Op);
// Subtract off the extra leading bits in the bigger type.		// Subtract off the extra leading bits in the bigger type.
return DAG.getNode(ISD::SUB, dl, NVT, Op,		return DAG.getNode(ISD::SUB, dl, NVT, Op,
DAG.getConstant(NVT.getSizeInBits() -		DAG.getConstant(NVT.getScalarSizeInBits() -
OVT.getSizeInBits(), NVT));		OVT.getScalarSizeInBits(), NVT));
}		}

SDValue DAGTypeLegalizer::PromoteIntRes_CTPOP(SDNode *N) {		SDValue DAGTypeLegalizer::PromoteIntRes_CTPOP(SDNode *N) {
// Zero extend to the promoted type and do the count there.		// Zero extend to the promoted type and do the count there.
SDValue Op = ZExtPromotedInteger(N->getOperand(0));		SDValue Op = ZExtPromotedInteger(N->getOperand(0));
return DAG.getNode(ISD::CTPOP, SDLoc(N), Op.getValueType(), Op);		return DAG.getNode(ISD::CTPOP, SDLoc(N), Op.getValueType(), Op);
}		}

▲ Show 20 Lines • Show All 2,707 Lines • Show Last 20 Lines

test/CodeGen/X86/pr20917.ll

This file was added.

				; RUN: llc < %s -mtriple=i686-none-linux-gnueabi -mattr=+sse2 \| FileCheck %s

				; CHECK: .LCPI0_1:
				; CHECK-NEXT: .long 32 # 0x20
				; CHECK-NEXT: .long 0 # 0x0
				; CHECK-NEXT: .long 32 # 0x20
				; CHECK-NEXT: .long 0 # 0x0
				; CHECK: psubq .LCPI0_1

				define <2 x i32> @test(<2 x i32> %x) {
				%1 = call <2 x i32> @llvm.ctlz.v2i32(<2 x i32> %x, i1 false)
				ret <2 x i32> %1
				}

				declare <2 x i32> @llvm.ctlz.v2i32(<2 x i32>, i1)