This is an archive of the discontinued LLVM Phabricator instance.

Differential D5312

R600/SI: Fix off by 1 error in used register count
ClosedPublic

Authored by arsenm on Sep 11 2014, 1:46 PM.

Download Raw Diff

Details

Reviewers

arsenm

Summary

The register numbers start at 0, so if only 1 register was used, this was reported as 0.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 13597.Sep 11 2014, 1:46 PM

arsenm retitled this revision from to R600/SI: Fix off by 1 error in used register count .

arsenm updated this object.

arsenm edited the test plan for this revision. (Show Details)

arsenm added a subscriber: Unknown Object (MLST).

Merge test with existing test

r217636 with the other way

This revision is now accepted and ready to land.Sep 11 2014, 4:01 PM

arsenm closed this revision.Sep 11 2014, 4:02 PM

Revision Contents

Path

Size

lib/

Target/

R600/

AMDGPUAsmPrinter.cpp

2 lines

test/

CodeGen/

R600/

no_vgpr_used.ll

8 lines

Diff 13597

lib/Target/R600/AMDGPUAsmPrinter.cpp

Context not available.
	llvm_unreachable("Unknown register class");	llvm_unreachable("Unknown register class");
	}	}
	unsigned hwReg = RI->getEncodingValue(reg) & 0xff;	unsigned hwReg = RI->getEncodingValue(reg) & 0xff;
	unsigned maxUsed = hwReg + width - 1;	unsigned maxUsed = hwReg + width;
	if (isSGPR) {	if (isSGPR) {
	MaxSGPR = maxUsed > MaxSGPR ? maxUsed : MaxSGPR;	MaxSGPR = maxUsed > MaxSGPR ? maxUsed : MaxSGPR;
	} else {	} else {
Context not available.

test/CodeGen/R600/no_vgpr_used.ll

This file was added.

				; RUN: llc -march=r600 -mcpu=SI -verify-machineinstrs < %s \| FileCheck -check-prefix=SI %s

				; SI-LABEL: @no_vgpr_used
				; SI: NumVgprs: 1
				define void @no_vgpr_used(i32 addrspace(1)* %out, i32 %x) nounwind {
				store i32 %x, i32 addrspace(1)* %out, align 4
				ret void
				}