[bindings/go] Add EraseFromParent

[aykevl]

Summary

After using ReplaceAllUsesWith on an instruction, it may be necessary to erase it even though it is dead.

[whitequark]

bindings/go/llvm/ir.go

1213

Nit: I'd call this EraseInstructionFromParent. (Also I'd deprecate EraseFromParent and rename it to EraseBasicBlockFromParent, but I'm not the Go bindings code owner so it's not my call.)

[aykevl]

bindings/go/llvm/ir.go

1213

Yes, that sounds better but I've kept it consistent with EraseFromParentAsFunction and EraseFromParentAsGlobal. Should it be changed, then?

[aykevl]

bindings/go/llvm/ir.go

1213

ping?

[whitequark]

bindings/go/llvm/ir.go

1213

I'm not the Go bindings code owner so it seems better to go with the conservative naming.

[aykevl]

Can someone merge this patch? I don't have commit access.

bindings/go/llvm/ir.go

1213

Do you know who the owner is, then? @pcc? I can't find anyone closer in the CODE_OWNERS.TXT file.

[aykevl]

Ping?
I don't have commit access.

[whitequark]

@aykevl I think you can ask for commit access, you've had more than a few patches merged.

[aykevl]

Asked for commit access and merged this change.

bindings/go/llvm/ir.go

func InsertBasicBlock(ref BasicBlock, name string) (bb BasicBlock) {
   bb.C = C.LLVMInsertBasicBlock(ref.C, cname)
   return
 }
 func (bb BasicBlock) EraseFromParent()          { C.LLVMDeleteBasicBlock(bb.C) }
 func (bb BasicBlock) MoveBefore(pos BasicBlock) { C.LLVMMoveBasicBlockBefore(bb.C, pos.C) }
 func (bb BasicBlock) MoveAfter(pos BasicBlock)  { C.LLVMMoveBasicBlockAfter(bb.C, pos.C) }
 
 // Operations on instructions
+func (v Value) EraseFromParentAsInstruction()      { C.LLVMInstructionEraseFromParent(v.C) }
 func (v Value) InstructionParent() (bb BasicBlock) { bb.C = C.LLVMGetInstructionParent(v.C); return }
 func (bb BasicBlock) FirstInstruction() (v Value)  { v.C = C.LLVMGetFirstInstruction(bb.C); return }
 func (bb BasicBlock) LastInstruction() (v Value)   { v.C = C.LLVMGetLastInstruction(bb.C); return }
 func NextInstruction(v Value) (rv Value)           { rv.C = C.LLVMGetNextInstruction(v.C); return }
 func PrevInstruction(v Value) (rv Value)           { rv.C = C.LLVMGetPreviousInstruction(v.C); return }
 
 // Operations on call sites
 func (v Value) SetInstructionCallConv(cc CallConv) {