Page MenuHomePhabricator

Fix raw address breakpoints not resolving
ClosedPublic

Authored by ted on Sep 7 2018, 2:17 PM.

Details

Summary

An address breakpoint of the form "b 0x1000" won't resolve if it's created while the process isn't running. This patch deletes Address::SectionWasDeleted, renames Address::SectionWasDeletedPrivate to SectionWasDeleted (and makes it public), and changes the section check in Breakpoint::ModulesChanged back to its original form

Diff Detail

Event Timeline

ted created this revision.Sep 7 2018, 2:17 PM
davide added a subscriber: davide.Sep 7 2018, 2:37 PM

Can you add a test for this behavior?

ted added a comment.Sep 7 2018, 3:03 PM

Yes, I'll add a new test to TestAddressBreakpoints.py.

ted updated this revision to Diff 164533.Sep 7 2018, 4:04 PM

Added a test to TestAddressBreakpoints.py that sets an address breakpoint before launch, launches, and checks to see if the breakpoint was hit.

jingham accepted this revision as: jingham.Sep 7 2018, 4:17 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 7 2018, 4:17 PM
ted closed this revision.Sep 10 2018, 11:20 AM