Page MenuHomePhabricator

[ARC] Prevent InstPrinter from crashing on unknown condition codes.
ClosedPublic

Authored by tatyana-krasnukha on Sep 6 2018, 4:34 AM.

Details

Summary

Instruction printer shouldn't crash with assertions due to incorrect input data. llvm_unreachable is not intended for runtime error handling.

Diff Detail

Repository
rL LLVM

Event Timeline

Thanks, can you add a test to make sure the disassembler doesn't crash in this case?

Added a test for bcc instruction with unknown condition code.

petecoup accepted this revision.Sep 6 2018, 12:54 PM

Great, thanks for doing this!

This revision is now accepted and ready to land.Sep 6 2018, 12:54 PM
This revision was automatically updated to reflect the committed changes.