This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix output file extension
ClosedPublic

Authored by yaxunl on Aug 27 2018, 9:15 PM.

Details

Summary

OffloadBundlingJobAction constructor accepts a list of JobAction as inputs.
The host JobAction is the last one. The file type of OffloadBundlingJobAction
should be determined by the host JobAction (the last one) instead of the first
one.

Since HIP emits LLVM bitcode for device compilation, device JobAction has
different file type as host Job Action. This bug causes incorrect output file
extension for HIP.

This patch fixes it by using the last input JobAction (host JobAction) to determine
file type of OffloadBundlingJobAction.

Diff Detail

Repository
rC Clang

Event Timeline

yaxunl created this revision.Aug 27 2018, 9:15 PM
tra accepted this revision.Aug 28 2018, 10:41 AM
This revision is now accepted and ready to land.Aug 28 2018, 10:41 AM
This revision was automatically updated to reflect the committed changes.