extend binop folds for selects to include true and false binops flag intersection
ClosedPublic
Actions

Authored by mcberg2017 on Aug 20 2018, 2:34 PM.

Details

Reviewers

spatel
wristow

Commits

rG0b838deddcfc: extend binop folds for selects to include true and false binops flag…
rL340222: extend binop folds for selects to include true and false binops flag…

Summary

This change address bug 38641

Diff Detail

Repository: rL LLVM

Event Timeline

The select_meta test has a directly related case in it that maps to the bug test case in https://bugs.llvm.org/show_bug.cgi?id=38641

mcberg2017 mentioned this in rL339938: add a missed case for binary op FMF propagation under select folds.Aug 20 2018, 2:41 PM

Add a test with FMF too since that was the motivation for rL339938?
Code change LGTM.

This revision is now accepted and ready to land.Aug 20 2018, 2:44 PM

Actually the other test in rL339938 shows the positive side, where both binops are fast to show the intersection in /test/Transforms/LoopVectorize/reduction.ll

Closed by commit rL340222: extend binop folds for selects to include true and false binops flag… (authored by mcberg2017). · Explain WhyAug 20 2018, 3:27 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 20 2018, 3:27 PM

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

Transforms/

InstCombine/

InstCombineSelect.cpp

3 lines

test/

Transforms/

InstCombine/

select_meta.ll

4 lines

Diff 161587

View Options

llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp