Page MenuHomePhabricator

[SampleFDO] Fix a bug in getOrCompHotCountThreshold/getOrCompColdCountThreshold
ClosedPublic

Authored by wmi on Aug 6 2018, 4:36 PM.

Details

Summary

getOrCompHotCountThreshold/getOrCompColdCountThreshold introduced in https://reviews.llvm.org/D45377 contain a bad mistake and will only return 1 or 0 instead of the true hot/cold cutoff value. The patch fixes the mistake. But the mistake seems not causing big performance difference according to internal server benchmarks testing.

Diff Detail

Repository
rL LLVM

Event Timeline

wmi created this revision.Aug 6 2018, 4:36 PM
danielcdh accepted this revision.Aug 7 2018, 8:42 AM
This revision is now accepted and ready to land.Aug 7 2018, 8:42 AM
This revision was automatically updated to reflect the committed changes.