This is an archive of the discontinued LLVM Phabricator instance.

Differential D50182

archie test fails at compilation time
ClosedPublic

Authored by santosh on Aug 2 2018, 5:56 AM.

Download Raw Diff

Details

Reviewers

MatzeB

Commits

rL338785: archie test fails at compilation time
rOLDT338785: archie test fails at compilation time

Summary

Because of the change in svn r338623 , about "cmake: Explicitely add current directory to include path" archie tests started regressing.

Diff Detail

Repository: rL LLVM

Event Timeline

santosh created this revision.Aug 2 2018, 5:56 AM

Herald added a subscriber: mgorny. · View Herald TranscriptAug 2 2018, 5:56 AM

LOoks like this benchmark is disabled on macs so I missed it. Thanks for the fix, LGTM

This revision is now accepted and ready to land.Aug 2 2018, 7:47 AM

santosh set the repository for this revision to rOLDT svn-test-suite.Aug 2 2018, 8:58 AM

Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 2 2018, 8:58 AM

do you need someone to commit this for you?

Closed by commit rOLDT338785: archie test fails at compilation time (authored by matze). · Explain WhyAug 2 2018, 4:34 PM

Closed by commit rL338785: archie test fails at compilation time (authored by matze). · Explain Why

This revision was automatically updated to reflect the committed changes.

I went ahead and committed this.

Thanks.

Revision Contents

Path

Size

test-suite/

trunk/

MultiSource/

Benchmarks/

Prolangs-C/

archie-client/

CMakeLists.txt

1 line

Diff 158862

test-suite/trunk/MultiSource/Benchmarks/Prolangs-C/archie-client/CMakeLists.txt

	include(CheckFunctionExists)			include(CheckFunctionExists)
	check_function_exists(re_comp HAVE_RE_COMP)			check_function_exists(re_comp HAVE_RE_COMP)

	if(HAVE_RE_COMP)			if(HAVE_RE_COMP)
	set(PROG archie)			set(PROG archie)
	if(TARGET_OS STREQUAL "SunOS")			if(TARGET_OS STREQUAL "SunOS")
	list(APPEND LDFLAGS -lsocket -lnsl)			list(APPEND LDFLAGS -lsocket -lnsl)
	endif()			endif()
	llvm_multisource()			llvm_multisource()
				target_include_directories(archie PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
	endif()			endif()