This is an archive of the discontinued LLVM Phabricator instance.

Differential D50015

Remove unnecessary newlines from break command help text.
ClosedPublic

Authored by teemperor on Jul 30 2018, 2:40 PM.

Details

Reviewers
None
Commits
rG129fe89ffb56: Remove unnecessary newlines from break command help text.
rLLDB338311: Remove unnecessary newlines from break command help text.
rL338311: Remove unnecessary newlines from break command help text.
Summary

We usually don't have trailing newlines in the short help strings. This just adds
unnecessary extra lines when printing the help text of these commands.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jul 30 2018, 2:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2018, 2:41 PM
Closed by commit rL338311: Remove unnecessary newlines from break command help text. (authored by teemperor). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 30 2018, 2:41 PM

Revision Contents

PathSize
lldb/
trunk/
source/
Interpreter/
4 lines

Diff 158081

lldb/trunk/source/Interpreter/CommandInterpreter.cpp

Show First 20 Lines • Show All 472 Lines • ▼ Show 20 Lines const char *break_regexes[][2] = {
{"^[\"']?(.*[^[:space:]\"'])[\"']?[[:space:]]*$", {"^[\"']?(.*[^[:space:]\"'])[\"']?[[:space:]]*$",
"breakpoint set --name '%1'"}}; "breakpoint set --name '%1'"}};
size_t num_regexes = llvm::array_lengthof(break_regexes); size_t num_regexes = llvm::array_lengthof(break_regexes);
std::unique_ptr<CommandObjectRegexCommand> break_regex_cmd_ap( std::unique_ptr<CommandObjectRegexCommand> break_regex_cmd_ap(
new CommandObjectRegexCommand( new CommandObjectRegexCommand(
*this, "_regexp-break", *this, "_regexp-break",
"Set a breakpoint using one of several shorthand formats.\n", "Set a breakpoint using one of several shorthand formats.",
"\n" "\n"
"_regexp-break <filename>:<linenum>\n" "_regexp-break <filename>:<linenum>\n"
" main.c:12 // Break at line 12 of " " main.c:12 // Break at line 12 of "
"main.c\n\n" "main.c\n\n"
"_regexp-break <linenum>\n" "_regexp-break <linenum>\n"
" 12 // Break at line 12 of current " " 12 // Break at line 12 of current "
"file\n\n" "file\n\n"
"_regexp-break 0x<address>\n" "_regexp-break 0x<address>\n"
Show All 32 Lines if (success) {
CommandObjectSP break_regex_cmd_sp(break_regex_cmd_ap.release()); CommandObjectSP break_regex_cmd_sp(break_regex_cmd_ap.release());
m_command_dict[break_regex_cmd_sp->GetCommandName()] = break_regex_cmd_sp; m_command_dict[break_regex_cmd_sp->GetCommandName()] = break_regex_cmd_sp;
} }
} }
std::unique_ptr<CommandObjectRegexCommand> tbreak_regex_cmd_ap( std::unique_ptr<CommandObjectRegexCommand> tbreak_regex_cmd_ap(
new CommandObjectRegexCommand( new CommandObjectRegexCommand(
*this, "_regexp-tbreak", *this, "_regexp-tbreak",
"Set a one-shot breakpoint using one of several shorthand formats.\n", "Set a one-shot breakpoint using one of several shorthand formats.",
"\n" "\n"
"_regexp-break <filename>:<linenum>\n" "_regexp-break <filename>:<linenum>\n"
" main.c:12 // Break at line 12 of " " main.c:12 // Break at line 12 of "
"main.c\n\n" "main.c\n\n"
"_regexp-break <linenum>\n" "_regexp-break <linenum>\n"
" 12 // Break at line 12 of current " " 12 // Break at line 12 of current "
"file\n\n" "file\n\n"
"_regexp-break 0x<address>\n" "_regexp-break 0x<address>\n"
▲ Show 20 Lines • Show All 2,533 Lines • Show Last 20 Lines