Page MenuHomePhabricator

Default getFile() to use the last accessed name in the FileEntry.
AbandonedPublic

Authored by klimek on Aug 12 2014, 1:49 AM.

Details

Reviewers
rsmith
Summary

With modules we start accessing headers for the first time while
reading the module map, which often has very different paths from the include
scanning logic.

Using the name by which the file was accessed gets us one step closer to the
right solution, which is using a FileName abstraction that decouples the name
by which a file was accessed from the FileEntry.

Diff Detail

Event Timeline

klimek updated this revision to Diff 12388.Aug 12 2014, 1:49 AM
klimek retitled this revision from to Default getFile() to use the last accessed name in the FileEntry..
klimek updated this object.
klimek edited the test plan for this revision. (Show Details)
klimek added a reviewer: rsmith.
klimek added a subscriber: Unknown Object (MLST).
rsmith edited edge metadata.Aug 12 2014, 3:57 PM

Seems reasonable as a short-term workaround. Can you add a test?

Added test and commited as r215541.

klimek abandoned this revision.Sep 8 2014, 3:07 AM