Page MenuHomePhabricator

[NewPM] Emit inliner NoDefinition missed optimization remark
ClosedPublic

Authored by tejohnson on May 7 2018, 7:47 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.May 7 2018, 7:47 AM
eraman added inline comments.May 7 2018, 11:17 AM
test/Other/new-pm-defaults.ll
117 ↗(On Diff #145465)

It is not obvious to me why they get swapped.

tejohnson added inline comments.May 7 2018, 11:59 AM
test/Other/new-pm-defaults.ll
117 ↗(On Diff #145465)

Due to the first change in Inliner.cpp - we now need to get the FunctionAnalysisManagerCGSCCProxy earlier than before. It is also accessed later for a different remark, and we don't need to re-run the analysis at that point since we have already done it.

eraman accepted this revision.May 7 2018, 6:30 PM

LGTM

This revision is now accepted and ready to land.May 7 2018, 6:30 PM
This revision was automatically updated to reflect the committed changes.