Page MenuHomePhabricator

Add ignore f/m group flags for compatibility

Authored by bubbles231 on Jul 17 2014, 11:49 AM.



Added f/m flags to be ignored. They are part of the clang_ignored_f_Group/clang_ignored_m_Group so there is no warning.

Diff Detail

Event Timeline

bubbles231 retitled this revision from to Add ignore f/m group flags for compatibility.
bubbles231 updated this object.
bubbles231 edited the test plan for this revision. (Show Details)
bubbles231 added a subscriber: Unknown Object (MLST).
bubbles231 updated this object.Jul 18 2014, 9:49 AM

Move a lot of flags to, Make this revision depend upon, and fixes some problems.

Make a patch that will apply with

rnk accepted this revision.Aug 4 2014, 2:20 PM
rnk edited edge metadata.

lgtm if you don't ignore -malign-double.

Sorry, I just did a search for unread reviews.


-malign-double is an ABI breaking flag, as it affects record layout. We should reject it with prejudice. :)


Amusing, we implement this behavior under -fms-compatibility.

This revision is now accepted and ready to land.Aug 4 2014, 2:20 PM

Thanks for looking at the revision! I made the changes and will commit as soon as is approved because this patch is dependent on that patch.

bubbles231 closed this revision.Aug 5 2014, 11:31 AM

Committed the changes with this commit: