This is an archive of the discontinued LLVM Phabricator instance.

[builtin-dump-struct] printf formats generation testing
ClosedPublic

Authored by paulsemel on Apr 15 2018, 3:15 AM.

Details

Reviewers
aaron.ballman
Summary

Added check for correct formats in CodeGen tests, to ensure we are printing the fields correctly.
Added a fix that outcomed from this previous add

Diff Detail

Repository
rC Clang

Event Timeline

paulsemel created this revision.Apr 15 2018, 3:15 AM
paulsemel updated this revision to Diff 142548.Apr 15 2018, 3:26 AM

Fixed typo..

paulsemel retitled this revision from [builtin-dump-struct] printf format checking to [builtin-dump-struct] printf formats generation testing.Apr 15 2018, 5:29 AM
This revision is now accepted and ready to land.Apr 16 2018, 12:51 PM

LGTM!

Nice to hear ! As for the last time, as I don't have any rights to push this, I would really appreciate if you could do it for me ! :)

aaron.ballman closed this revision.Apr 17 2018, 5:01 AM

I've committed in r330185, thank you for the patch!