Page MenuHomePhabricator

Add a test for setting the load address of a module with differing physical/virtual addresses
ClosedPublic

Authored by labath on Mar 21 2018, 7:51 AM.

Details

Summary

First attempt at landing D42145 was reverted because it caused test
failures on some android devices. It turned out this was because these
devices had vdso modules with differing physical and virtual addresses.
This was not caught earlier because all of the modules in our tests
either lack physical addresses or have them identical to virtual ones.

In the discussion on the patch, we came to the conclusion that in the
scenario where we are merely setting a load address of a module (for
example from a dynamic loader plugin), we should always use virtual
addresses (i.e., preserve status quo). This patch adds a test to make
sure we don't regress in that direction.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Mar 21 2018, 7:51 AM
owenpshaw accepted this revision.Mar 23 2018, 9:12 AM

Looks good to me. Thanks!

This revision is now accepted and ready to land.Mar 23 2018, 9:12 AM
This revision was automatically updated to reflect the committed changes.