This is an archive of the discontinued LLVM Phabricator instance.

Set dso_local when clearing dllimport
ClosedPublic

Authored by espindola on Mar 20 2018, 7:05 PM.

Details

Reviewers
rnk
echristo

Diff Detail

Event Timeline

espindola created this revision.Mar 20 2018, 7:05 PM
rnk accepted this revision.Mar 27 2018, 12:16 PM

lgtm

I'd add more tests but I can't think of ways to remove the dll attributes, only to flip them.

Do we already have dso_local tests for this similar case:

__declspec(dllimport) void f();
void g() { f(); } // use it
void f() { }

It flips from dllimport to dllexport.

This revision is now accepted and ready to land.Mar 27 2018, 12:16 PM