This is an archive of the discontinued LLVM Phabricator instance.

Differential D44649

Set dso_local for guid decls
ClosedPublic

Authored by • espindola on Mar 19 2018, 1:56 PM.

Details

Reviewers
rnk
echristo

Diff Detail

Event Timeline

• espindola created this revision.Mar 19 2018, 1:56 PM
rnk accepted this revision.Mar 19 2018, 5:18 PM

Yep, these are pretty much always local.

This revision is now accepted and ready to land.Mar 19 2018, 5:18 PM
• espindola closed this revision.Mar 20 2018, 8:46 AM

327991

Revision Contents

PathSize
lib/
CodeGen/
1 line
test/
CodeGenCXX/
2 lines

Diff 139002

lib/CodeGen/CodeGenModule.cpp

Show First 20 Lines • Show All 1,915 Lines • ▼ Show 20 LinesConstantAddress CodeGenModule::GetAddrOfUuidDescriptor(
llvm::Constant *Init = EmitUuidofInitializer(Uuid); llvm::Constant *Init = EmitUuidofInitializer(Uuid);
assert(Init && "failed to initialize as constant"); assert(Init && "failed to initialize as constant");
auto *GV = new llvm::GlobalVariable( auto *GV = new llvm::GlobalVariable(
getModule(), Init->getType(), getModule(), Init->getType(),
/*isConstant=*/true, llvm::GlobalValue::LinkOnceODRLinkage, Init, Name); /*isConstant=*/true, llvm::GlobalValue::LinkOnceODRLinkage, Init, Name);
if (supportsCOMDAT()) if (supportsCOMDAT())
GV->setComdat(TheModule.getOrInsertComdat(GV->getName())); GV->setComdat(TheModule.getOrInsertComdat(GV->getName()));
setDSOLocal(GV);
return ConstantAddress(GV, Alignment); return ConstantAddress(GV, Alignment);
} }
ConstantAddress CodeGenModule::GetWeakRefReference(const ValueDecl *VD) { ConstantAddress CodeGenModule::GetWeakRefReference(const ValueDecl *VD) {
const AliasAttr *AA = VD->getAttr<AliasAttr>(); const AliasAttr *AA = VD->getAttr<AliasAttr>();
assert(AA && "No alias?"); assert(AA && "No alias?");
CharUnits Alignment = getContext().getDeclAlign(VD); CharUnits Alignment = getContext().getDeclAlign(VD);
▲ Show 20 Lines • Show All 3,083 Lines • Show Last 20 Lines

test/CodeGenCXX/microsoft-templ-uuidof.cpp

Show All 9 Lines
struct B {}; struct B {};
template <> template <>
struct __declspec(uuid("{BBBBBBBB-BBBB-BBBB-BBBB-BBBBBBBBBBBB}")) X<B> {}; struct __declspec(uuid("{BBBBBBBB-BBBB-BBBB-BBBB-BBBBBBBBBBBB}")) X<B> {};
struct __declspec(uuid("{CCCCCCCC-CCCC-CCCC-CCCC-CCCCCCCCCCCC}")) C {}; struct __declspec(uuid("{CCCCCCCC-CCCC-CCCC-CCCC-CCCCCCCCCCCC}")) C {};
// CHECK-DAG: @_GUID_aaaaaaaa_aaaa_aaaa_aaaa_aaaaaaaaaaaa = linkonce_odr dso_local
const _GUID &xa = __uuidof(X<A>); const _GUID &xa = __uuidof(X<A>);
// CHECK-DAG: @"?xa@@3ABU_GUID@@B" = {{.*}} @_GUID_aaaaaaaa_aaaa_aaaa_aaaa_aaaaaaaaaaaa // CHECK-DAG: @"?xa@@3ABU_GUID@@B" = {{.*}} @_GUID_aaaaaaaa_aaaa_aaaa_aaaa_aaaaaaaaaaaa
const _GUID &xb = __uuidof(X<B>); const _GUID &xb = __uuidof(X<B>);
// CHECK-DAG: @"?xb@@3ABU_GUID@@B" = {{.*}} @_GUID_bbbbbbbb_bbbb_bbbb_bbbb_bbbbbbbbbbbb // CHECK-DAG: @"?xb@@3ABU_GUID@@B" = {{.*}} @_GUID_bbbbbbbb_bbbb_bbbb_bbbb_bbbbbbbbbbbb
const _GUID &xc = __uuidof(X<C>); const _GUID &xc = __uuidof(X<C>);
// CHECK-DAG: @"?xc@@3ABU_GUID@@B" = {{.*}} @_GUID_cccccccc_cccc_cccc_cccc_cccccccccccc // CHECK-DAG: @"?xc@@3ABU_GUID@@B" = {{.*}} @_GUID_cccccccc_cccc_cccc_cccc_cccccccccccc
Show All 12 Lines