Page MenuHomePhabricator

[mips] Add support for -modd-spreg/-mno-odd-spreg
ClosedPublic

Authored by dsanders on Jul 9 2014, 5:56 AM.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 11192.Jul 9 2014, 5:56 AM
dsanders retitled this revision from to [mips] Add support for -modd-spreg/-mno-odd-spreg.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added reviewers: atanasyan, mpf.
mpf edited edge metadata.Jul 9 2014, 6:22 AM

Looks OK.

Is it possible to add a configure time option to set -mno-odd-spreg by default? And also a configure time setting to specify the default -mfp option?

The reason is to enable building tools which target a specific ABI variant without extra options giving a system integrator the chance to control the ABI variant which is generally used. In the android NDK this would be set to -mfpxx and -mno-odd-spreg.

Matthew

Is it possible to add a configure time option to set -mno-odd-spreg by default? And also a configure time setting to specify the default -mfp option?

I don't know I'm afraid. I would have thought that this is possible but I don't know how yet.

atanasyan accepted this revision.Jul 9 2014, 8:12 AM
atanasyan edited edge metadata.

LGTM with the small note.

include/clang/Driver/Options.td
1242

Not sure that we need to make this help text visible by default. Unfortunately there is no well defined policy. Most of "m" options do not have help text or have Flags<[HelpHidden]> flag.

This revision is now accepted and ready to land.Jul 9 2014, 8:12 AM
dsanders closed this revision.Jul 10 2014, 3:48 AM
dsanders added inline comments.Jul 10 2014, 3:49 AM
include/clang/Driver/Options.td
1242

Before committing I added Flags<[HelpHidden]> for consistency with the others.