Page MenuHomePhabricator

Delete the copy constructor for llvm::yaml::Node
ClosedPublic

Authored by jordan_rose on Mar 9 2018, 10:29 AM.

Details

Reviewers
arphaman
Summary

The nodes keep a reference back to the original document, but the document is streamed, not read all into memory at once, and the position is part of the state. If nodes are ever copied, the document position can end up being advanced more than once.

This did not reveal any problems in LLVM or Clang but caught a handful over in Swift!

Diff Detail

Repository
rL LLVM

Event Timeline

jordan_rose created this revision.Mar 9 2018, 10:29 AM
arphaman accepted this revision.Mar 22 2018, 10:28 PM

LG, go for it

This revision is now accepted and ready to land.Mar 22 2018, 10:28 PM