Set dso_local on external rtti GVs
ClosedPublic

Authored by espindola on Mar 7 2018, 3:40 PM.

Details

Reviewers
rnk
echristo
Summary

In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many callers as possible just call setGVProperties so that we can centralize the logic there.

This patch then makes setGVProperties able to handle null Decls.

Diff Detail

espindola created this revision.Mar 7 2018, 3:40 PM
rnk accepted this revision.Mar 14 2018, 10:54 AM
rnk added inline comments.
lib/CodeGen/ItaniumCXXABI.cpp
2618–2620

This looks like Ty->getAsCXXRecordDecl().

This revision is now accepted and ready to land.Mar 14 2018, 10:54 AM