Page MenuHomePhabricator

Fix ar command line expansion on Windows.
ClosedPublic

Authored by dmikulin on Mar 1 2018, 4:47 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

dmikulin created this revision.Mar 1 2018, 4:47 PM
dmikulin added a reviewer: Bigcheese.
dmikulin added a subscriber: llvm-commits.
Bigcheese accepted this revision.Mar 1 2018, 5:14 PM

This is good, but this should be using llvm-ar's failIfError instead of adding ExitOnError. Moving the error handling to ExitOnError should be a separate commit if done.

Really all of our tools should be doing this, as it also (mostly) properly handles unicode paths on Windows.

This revision is now accepted and ready to land.Mar 1 2018, 5:14 PM
espindola accepted this revision.Mar 1 2018, 6:26 PM
espindola added a subscriber: espindola.

LGTM with the same request: Use failIfError.

This revision was automatically updated to reflect the committed changes.