Page MenuHomePhabricator

[RewriteStatepoints] Do not instert Store before Phi
Needs RevisionPublic

Authored by yrouban on Mar 1 2018, 4:17 AM.

Details

Summary

When Store instructions are emitted they must not be followed by phi nodes.

Diff Detail

Event Timeline

yrouban created this revision.Mar 1 2018, 4:17 AM
dneilson requested changes to this revision.Mar 1 2018, 6:54 AM

Please add a test case that demonstrates the patch in action (and would prevent regressions).

This revision now requires changes to proceed.Mar 1 2018, 6:54 AM
yrouban marked an inline comment as done.Apr 23 2019, 10:38 PM
yrouban added inline comments.
lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
1869

Use getFirstInsertionPt() instead of getFirstNonPHI()