Page MenuHomePhabricator

Make module use diagnostics refer to the top-level module
ClosedPublic

Authored by djasper on Feb 23 2018, 5:24 AM.

Details

Reviewers
rsmith
Summary

All use declarations need to be directly placed in the top-level module anyway, knowing the submodule doesn't really help. The header that has the offending #include can easily be seen in the diagnostics source location.

Diff Detail

Event Timeline

djasper created this revision.Feb 23 2018, 5:24 AM
rsmith accepted this revision.Feb 23 2018, 2:31 PM

Makes sense -- as dependencies can only be declared on top-level modules, that's what we should be talking about here.

This revision is now accepted and ready to land.Feb 23 2018, 2:31 PM
djasper closed this revision.Feb 23 2018, 10:56 PM

Submitted as r326023.