This is an archive of the discontinued LLVM Phabricator instance.

Fix unresolved symbols when loading gold plugin
ClosedPublic

Authored by volkalexey on Jun 24 2014, 7:43 AM.

Download Raw Diff

Details

Reviewers

Commits

rG2ecf636073ec: Fix unresolved symbols when loading gold plugin
rL211675: Fix unresolved symbols when loading gold plugin

Summary

Gold plugin is missed some symbols when built using configure and make.
LLVMgold.so: could not load plugin library: LLVMgold.so: undefined symbol: LLVMInitializeSparcTarget

When using cmake I don't see these errors.
This error was introduced with changes to plugin on revision 211315.

Diff Detail

Event Timeline

volkalexey updated this revision to Diff 10788.Jun 24 2014, 7:43 AM

volkalexey retitled this revision from to Fix unresolved symbols when loading gold plugin.

volkalexey updated this object.

volkalexey edited the test plan for this revision. (Show Details)

volkalexey added a reviewer: • rafael.

volkalexey set the repository for this revision to rL LLVM.

volkalexey added a subscriber: Unknown Object (MLST).

zinovy.nis added a subscriber: zinovy.nis.Jun 24 2014, 8:16 AM

Lgtm. Thanks and sorry!

Closed by commit rL211675 (authored by volkalex).

Revision Contents

Path

Size

tools/

gold/

Makefile

5 lines

Diff 10788

tools/gold/Makefile

	#===- tools/gold/Makefile ----------------------------------- Makefile --===##			#===- tools/gold/Makefile ----------------------------------- Makefile --===##
	#			#
	# The LLVM Compiler Infrastructure			# The LLVM Compiler Infrastructure
	#			#
	# This file is distributed under the University of Illinois Open Source			# This file is distributed under the University of Illinois Open Source
	# License. See LICENSE.TXT for details.			# License. See LICENSE.TXT for details.
	#			#
	##===----------------------------------------------------------------------===##			##===----------------------------------------------------------------------===##

	LEVEL := ../..			LEVEL := ../..
	LIBRARYNAME := LLVMgold			LIBRARYNAME := LLVMgold
	LINK_COMPONENTS := support
	LINK_LIBS_IN_SHARED := 1			LINK_LIBS_IN_SHARED := 1
	SHARED_LIBRARY := 1			SHARED_LIBRARY := 1
	LOADABLE_MODULE := 1			LOADABLE_MODULE := 1

	EXPORTED_SYMBOL_FILE = $(PROJ_SRC_DIR)/gold.exports			EXPORTED_SYMBOL_FILE = $(PROJ_SRC_DIR)/gold.exports

	# Include this here so we can get the configuration of the targets			# Include this here so we can get the configuration of the targets
	# that have been configured for construction. We have to do this			# that have been configured for construction. We have to do this
	# early so we can set up LINK_COMPONENTS before including Makefile.rules			# early so we can set up LINK_COMPONENTS before including Makefile.rules
	include $(LEVEL)/Makefile.config			include $(LEVEL)/Makefile.config

				LINK_COMPONENTS := $(TARGETS_TO_BUILD) LTO

	# Because off_t is used in the public API, the largefile parts are required for			# Because off_t is used in the public API, the largefile parts are required for
	# ABI compatibility.			# ABI compatibility.
	CXXFLAGS += -I$(BINUTILS_INCDIR) -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64			CXXFLAGS += -I$(BINUTILS_INCDIR) -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
	LDFLAGS += -L$(SharedLibDir)/$(SharedPrefix)			LDFLAGS += -L$(SharedLibDir)/$(SharedPrefix)

	include $(LEVEL)/Makefile.common			include $(LEVEL)/Makefile.common

	LIBS += -lLTO