Page MenuHomePhabricator

[clang-cl] Let /FA output use intel assembly.
ClosedPublic

Authored by thakis on Jan 16 2018, 6:14 PM.

Details

Reviewers
hans
Summary

cl.exe's assembly output is in intel syntax, so clang-cl's should be too, PR35031.

Diff Detail

Event Timeline

thakis created this revision.Jan 16 2018, 6:14 PM
hans accepted this revision.Jan 17 2018, 5:19 AM

lgtm, thanks for fixing!

This revision is now accepted and ready to land.Jan 17 2018, 5:19 AM
thakis closed this revision.Jan 17 2018, 5:35 AM

r322652, thanks!

seurer added a subscriber: seurer.Jan 17 2018, 8:44 AM

This patch fails on powerpc64

http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14380
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/13463

  • TEST 'Clang :: Driver/masm.c' FAILED ****

Script:

/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang -target i386-unknown-linux -masm=intel -S /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c -# 2>&1 | /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/FileCheck --check-prefix=CHECK-INTEL /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang -target i386-unknown-linux -masm=att -S /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c -# 2>&1 | /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/FileCheck --check-prefix=CHECK-ATT /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang -target i386-unknown-linux -S -masm=somerequired /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c -# 2>&1 | /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/FileCheck --check-prefix=CHECK-SOMEREQUIRED /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang -target arm-unknown-eabi -S -masm=intel /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c -# 2>&1 | /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/FileCheck --check-prefix=CHECK-ARM /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c

/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang --driver-mode=cl /FA -### -- /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c 2>&1 | /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/FileCheck --check-prefix=CHECK-CL /home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c

Exit Code: 1

Command Output (stderr):

/home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c:12:14: error: expected string not found in input
// CHECK-CL: -x86-asm-syntax=intel

^

<stdin>:1:1: note: scanning from here
clang version 7.0.0 (trunk 322652)
^
<stdin>:6:930: note: possible intended match here
"/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/bin/clang-6.0" "-cc1" "-triple" "powerpc64le-pc-windows-msvc19.11.0" "-S" "-disable-free" "-main-file-name" "masm.c" "-mrelocation-model" "static" "-mthread-model" "posix" "-relaxed-aliasing" "-fmath-errno" "-masm-verbose" "-mconstructor-aliases" "-target-cpu" "ppc64le" "-mfloat-abi" "hard" "-D_MT" "-flto-visibility-public-std" "--dependent-lib=libcmt" "--dependent-lib=oldnames" "-stack-protector" "2" "-fdiagnostics-format" "msvc" "-dwarf-column-info" "-debugger-tuning=gdb" "-momit-leaf-frame-pointer" "-resource-dir" "/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/lib/clang/7.0.0" "-internal-isystem" "/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/lib/clang/7.0.0/include" "-fdebug-compilation-dir" "/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/tools/clang/test/Driver" "-ferror-limit" "19" "-fmessage-length" "0" "-fno-signed-char" "-fno-use-cxa-atexit" "-fms-extensions" "-fms-compatibility" "-fms-compatibility-version=19.11" "-fdelayed-template-parsing" "-fobjc-runtime=gcc" "-fseh-exceptions" "-fdiagnostics-show-option" "-o" "masm.asm" "-x" "c" "/home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/tools/clang/test/Driver/masm.c"