This is an archive of the discontinued LLVM Phabricator instance.

Add va_start()/va_copy()/va_end to Builtins.def
ClosedPublic

Authored by thakis on Jan 15 2018, 12:19 PM.

Details

Reviewers
hans
Summary

That way, clang suggests including stdarg.h when these are used in C files.

Diff Detail

Event Timeline

thakis created this revision.Jan 15 2018, 12:19 PM
hans accepted this revision.Jan 16 2018, 6:19 AM

lgtm

Seems that some of these are tested in Sema/implicit-builtin-decl.c, but it doesn't look exhaustive and I'm not sure it's worth adding these.

This revision is now accepted and ready to land.Jan 16 2018, 6:19 AM
thakis closed this revision.Jan 16 2018, 8:57 AM

r322573, thanks!

Yes, I looked at the same file and came to the same conclusion regarding a test :-)