This is an archive of the discontinued LLVM Phabricator instance.

Differential D41713

[Myriad] Remove invalidated -elf flag for MoviAsm
ClosedPublic

Authored by waltl on Jan 3 2018, 1:30 PM.

Details

Reviewers
jyknight
Commits
rG215284d089dd: [Myriad] Remove invalidated -elf flag for MoviAsm
rL322023: [Myriad] Remove invalidated -elf flag for MoviAsm
rC322023: [Myriad] Remove invalidated -elf flag for MoviAsm
Summary

The flag has been deprecated, and is becoming invalid in the latest
MDK.

Diff Detail

Repository
rC Clang

Event Timeline

waltl created this revision.Jan 3 2018, 1:30 PM
jyknight accepted this revision.Jan 8 2018, 12:35 PM
This revision is now accepted and ready to land.Jan 8 2018, 12:35 PM
Closed by commit rC322023: [Myriad] Remove invalidated -elf flag for MoviAsm (authored by waltl). · Explain WhyJan 8 2018, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
ToolChains/
1 line
test/
Driver/
2 lines

Diff 128970

lib/Driver/ToolChains/Myriad.cpp

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Linesvoid tools::SHAVE::Assembler::ConstructJob(Compilation &C, const JobAction &JA,
CmdArgs.push_back("-noSPrefixing"); CmdArgs.push_back("-noSPrefixing");
CmdArgs.push_back("-a"); // Mystery option. CmdArgs.push_back("-a"); // Mystery option.
Args.AddAllArgValues(CmdArgs, options::OPT_Wa_COMMA, options::OPT_Xassembler); Args.AddAllArgValues(CmdArgs, options::OPT_Wa_COMMA, options::OPT_Xassembler);
for (const Arg *A : Args.filtered(options::OPT_I, options::OPT_isystem)) { for (const Arg *A : Args.filtered(options::OPT_I, options::OPT_isystem)) {
A->claim(); A->claim();
CmdArgs.push_back( CmdArgs.push_back(
Args.MakeArgString(std::string("-i:") + A->getValue(0))); Args.MakeArgString(std::string("-i:") + A->getValue(0)));
} }
CmdArgs.push_back("-elf"); // Output format.
CmdArgs.push_back(II.getFilename()); CmdArgs.push_back(II.getFilename());
CmdArgs.push_back( CmdArgs.push_back(
Args.MakeArgString(std::string("-o:") + Output.getFilename())); Args.MakeArgString(std::string("-o:") + Output.getFilename()));
std::string Exec = std::string Exec =
Args.MakeArgString(getToolChain().GetProgramPath("moviAsm")); Args.MakeArgString(getToolChain().GetProgramPath("moviAsm"));
C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Exec), C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Exec),
CmdArgs, Inputs)); CmdArgs, Inputs));
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines

test/Driver/myriad-toolchain.c

Show All 35 Lines
// or just "moviCompile" depending on whether moviCompile is found. // or just "moviCompile" depending on whether moviCompile is found.
// As such, we test only for a trailing quote in its rendering. // As such, we test only for a trailing quote in its rendering.
// The same goes for "moviAsm". // The same goes for "moviAsm".
// RUN: %clang -target shave-myriad -mcpu=myriad2.2 -c -### %s -isystem somewhere -Icommon -Wa,-yippee 2>&1 \ // RUN: %clang -target shave-myriad -mcpu=myriad2.2 -c -### %s -isystem somewhere -Icommon -Wa,-yippee 2>&1 \
// RUN: | FileCheck %s -check-prefix=MOVICOMPILE // RUN: | FileCheck %s -check-prefix=MOVICOMPILE
// MOVICOMPILE: moviCompile{{(.exe)?}}" "-S" "-fno-exceptions" "-DMYRIAD2" "-mcpu=myriad2.2" "-isystem" "somewhere" "-I" "common" // MOVICOMPILE: moviCompile{{(.exe)?}}" "-S" "-fno-exceptions" "-DMYRIAD2" "-mcpu=myriad2.2" "-isystem" "somewhere" "-I" "common"
// MOVICOMPILE: moviAsm{{(.exe)?}}" "-no6thSlotCompression" "-cv:myriad2.2" "-noSPrefixing" "-a" // MOVICOMPILE: moviAsm{{(.exe)?}}" "-no6thSlotCompression" "-cv:myriad2.2" "-noSPrefixing" "-a"
// MOVICOMPILE: "-yippee" "-i:somewhere" "-i:common" "-elf" // MOVICOMPILE: "-yippee" "-i:somewhere" "-i:common"
// RUN: %clang -target shave-myriad -c -### %s -DEFINE_ME -UNDEFINE_ME 2>&1 \ // RUN: %clang -target shave-myriad -c -### %s -DEFINE_ME -UNDEFINE_ME 2>&1 \
// RUN: | FileCheck %s -check-prefix=DEFINES // RUN: | FileCheck %s -check-prefix=DEFINES
// DEFINES: "-D" "EFINE_ME" "-U" "NDEFINE_ME" // DEFINES: "-D" "EFINE_ME" "-U" "NDEFINE_ME"
// RUN: %clang -target shave-myriad -c -### %s -Icommon -iquote quotepath -isystem syspath 2>&1 \ // RUN: %clang -target shave-myriad -c -### %s -Icommon -iquote quotepath -isystem syspath 2>&1 \
// RUN: | FileCheck %s -check-prefix=INCLUDES // RUN: | FileCheck %s -check-prefix=INCLUDES
// INCLUDES: "-iquote" "quotepath" "-isystem" "syspath" // INCLUDES: "-iquote" "quotepath" "-isystem" "syspath"
Show All 38 Lines