Page MenuHomePhabricator

[polly] Support the new DiagnosticRemarks

Authored by simbuerg on Jun 17 2014, 1:39 AM.



Add support for generating optimization remarks after completing the
detection of Scops.
The goal is to provide end-users with useful hints about opportunities that
help to increase the size of the detected Scops in their code.

By default the remark is unspecified and the debug location is empty. Future
patches have to expand on the messages generated.

This patch brings a simple test case for ReportFuncCall to demonstrate the

Reports all missed opportunities to increase the size/number of valid
clang <...> -Rpass-missed="polly-detect" <...>
opt <...> -pass-remarks-missed="polly-detect" <...>

Reports beginning and end of all valid Scops:
clang <...> -Rpass="polly-detect" <...>
opt <...> -pass-remarks="polly-detect" <...>

Diff Detail


Event Timeline

simbuerg updated this revision to Diff 10478.Jun 17 2014, 1:39 AM
simbuerg retitled this revision from to [polly] Support the new DiagnosticRemarks.
simbuerg updated this object.
simbuerg edited the test plan for this revision. (Show Details)
dpeixott accepted this revision.Jun 20 2014, 10:17 AM
dpeixott added a reviewer: dpeixott.
dpeixott added a subscriber: dpeixott.

Some minor c++11 suggestions. LGTM with those changes.

144 ↗(On Diff #10478)

Mark these new functions as override.

798 ↗(On Diff #10478)

Can use c++11 range-based for.

This revision is now accepted and ready to land.Jun 20 2014, 10:17 AM
dpeixott added a subscriber: Unknown Object (MLST).Jun 20 2014, 10:46 AM

Adding llvm-commits to CC.

simbuerg closed this revision.Jun 26 2014, 3:15 AM
simbuerg updated this revision to Diff 10882.

Closed by commit rL211769 (authored by @simbuerg).