This is an archive of the discontinued LLVM Phabricator instance.

Differential D41641

[MC] - Stop ignoring invalid meta data symbols.
ClosedPublic

Authored by grimar on Dec 30 2017, 1:34 AM.

Details

Reviewers
• rafael
grimar
Commits
rG7672eb84af7f: [MC] - Stop ignoring invalid meta data symbols.
rL321599: [MC] - Stop ignoring invalid meta data symbols.
Summary

Previously llvm-mc would silently accept code from testcase,
that contains invalid metadata symbol in section declaration.

Patch fixes the issue.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Dec 30 2017, 1:34 AM
Herald added a subscriber: emaste. · View Herald TranscriptDec 30 2017, 1:34 AM
grimar accepted this revision.Dec 30 2017, 11:41 PM

Accepted by Rafael in mail list.

This revision is now accepted and ready to land.Dec 30 2017, 11:41 PM
Closed by commit rL321599: [MC] - Stop ignoring invalid meta data symbols. (authored by grimar). · Explain WhyDec 30 2017, 11:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
MC/
MCParser/
2 lines
test/
MC/
ELF/
10 lines

Diff 128368

llvm/trunk/lib/MC/MCParser/ELFAsmParser.cpp

Show First 20 Lines • Show All 441 Lines • ▼ Show 20 Lines
bool ELFAsmParser::parseMetadataSym(MCSymbolELF *&Associated) { bool ELFAsmParser::parseMetadataSym(MCSymbolELF *&Associated) {
MCAsmLexer &L = getLexer(); MCAsmLexer &L = getLexer();
if (L.isNot(AsmToken::Comma)) if (L.isNot(AsmToken::Comma))
return TokError("expected metadata symbol"); return TokError("expected metadata symbol");
Lex(); Lex();
StringRef Name; StringRef Name;
if (getParser().parseIdentifier(Name)) if (getParser().parseIdentifier(Name))
return true; return TokError("invalid metadata symbol");
Associated = dyn_cast_or_null<MCSymbolELF>(getContext().lookupSymbol(Name)); Associated = dyn_cast_or_null<MCSymbolELF>(getContext().lookupSymbol(Name));
if (!Associated || !Associated->isInSection()) if (!Associated || !Associated->isInSection())
return TokError("symbol is not in a section: " + Name); return TokError("symbol is not in a section: " + Name);
return false; return false;
} }
bool ELFAsmParser::maybeParseUniqueID(int64_t &UniqueID) { bool ELFAsmParser::maybeParseUniqueID(int64_t &UniqueID) {
MCAsmLexer &L = getLexer(); MCAsmLexer &L = getLexer();
▲ Show 20 Lines • Show All 393 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ELF/metadata-declaration-errors.s

// RUN: not llvm-mc -triple x86_64-pc-linux-gnu %s \
// RUN: -filetype=obj -o %t.o 2>&1 | FileCheck %s
// Check we do not silently ignore invalid metadata symbol (123).
// CHECK: error: invalid metadata symbol
.section .foo,"a"
.quad 0
.section bar,"ao",@progbits,123