This is an archive of the discontinued LLVM Phabricator instance.

Differential D40921

[libFuzzer] standalone fuzzer: close file after reading
AcceptedPublic

Authored by jzawadzki on Dec 6 2017, 1:52 PM.

Details

Reviewers
kcc
Summary

Add missing fclose() after fread() to avoid resource leak.

Diff Detail

Event Timeline

jzawadzki created this revision.Dec 6 2017, 1:52 PM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptDec 6 2017, 1:52 PM
kcc accepted this revision.Dec 6 2017, 1:54 PM
kcc added a subscriber: kcc.

LGTM, thanks!

This revision is now accepted and ready to land.Dec 6 2017, 1:54 PM

Revision Contents

Diff 125802

StandaloneFuzzTargetMain.c

Show All 28 Lines for (int i = 1; i < argc; i++) {
FILE *f = fopen(argv[i], "r"); FILE *f = fopen(argv[i], "r");
assert(f); assert(f);
fseek(f, 0, SEEK_END); fseek(f, 0, SEEK_END);
size_t len = ftell(f); size_t len = ftell(f);
fseek(f, 0, SEEK_SET); fseek(f, 0, SEEK_SET);
unsigned char *buf = (unsigned char*)malloc(len); unsigned char *buf = (unsigned char*)malloc(len);
size_t n_read = fread(buf, 1, len, f); size_t n_read = fread(buf, 1, len, f);
assert(n_read == len); assert(n_read == len);
fclose(f);
LLVMFuzzerTestOneInput(buf, len); LLVMFuzzerTestOneInput(buf, len);
free(buf); free(buf);
fprintf(stderr, "Done: %s: (%zd bytes)\n", argv[i], n_read); fprintf(stderr, "Done: %s: (%zd bytes)\n", argv[i], n_read);
} }
} }