This is an archive of the discontinued LLVM Phabricator instance.

Differential D40402

Update clang test for llvm using FILE_FLAG_DELETE_ON_CLOSE
AbandonedPublic

Authored by • rafael on Nov 23 2017, 2:01 PM.

Details

Reviewers
rnk
Summary

This completes the temporary file handling saga.

Diff Detail

Event Timeline

• rafael created this revision.Nov 23 2017, 2:01 PM
• rafael abandoned this revision.Nov 24 2017, 9:48 AM

I found a way to use FILE_FLAG_DELETE_ON_CLOSE with fewer changes.

amccarth added a subscriber: amccarth.Nov 27 2017, 8:21 AM

Revision Contents

PathSize
test/
Modules/
11 lines
4 lines

Diff 124112

test/Modules/signal-on-windows.m

  • This file was added.
// REQUIRES: crash-recovery && system-windows
// RUN: rm -rf %t
// Crash building module.
// RUN: not --crash %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -I%S/Inputs %s
// On windows we always completely delete the lock
// RUN: find %t -name "crash-*.pcm.lock" | count 0
// RUN: find %t -name "crash-*.pcm.lock-*" | count 0
@import crash;

test/Modules/signal.m

// REQUIRES: crash-recovery // REQUIRES: crash-recovery && !system-windows
// RUN: rm -rf %t // RUN: rm -rf %t
// Crash building module. // Crash building module.
// RUN: not --crash %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -I%S/Inputs %s // RUN: not --crash %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -I%S/Inputs %s
// The dead symlink is still around, but the underlying lock file is gone. // The dead lock is still around, but the temp file file is gone.
// RUN: find %t -name "crash-*.pcm.lock" | count 1 // RUN: find %t -name "crash-*.pcm.lock" | count 1
// RUN: find %t -name "crash-*.pcm.lock-*" | count 0 // RUN: find %t -name "crash-*.pcm.lock-*" | count 0
@import crash; @import crash;