Page MenuHomePhabricator

[Modules TS] Added re-export support
ClosedPublic

Authored by hamzasood on Nov 20 2017, 3:10 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hamzasood created this revision.Nov 20 2017, 3:10 PM
rsmith accepted this revision.Nov 20 2017, 5:26 PM

Thanks, looks great.

test/CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.export/p1.cpp
22 ↗(On Diff #123666)

Maybe consider adding one more module to this test: a module that is imported into this module but *not* re-exported.

This revision is now accepted and ready to land.Nov 20 2017, 5:26 PM
boris edited edge metadata.Nov 20 2017, 10:47 PM

LGTM. Will be happy to also run our re-export tests in build2 once this is merged.

This revision was automatically updated to reflect the committed changes.
boris added a comment.Nov 22 2017, 4:15 AM

All our tests pass as well. Thanks for your work!