I don't think there is any functionality change, but the code is easier to understand IMHO.
Details
Diff Detail
Event Timeline
tools/dsymutil/dsymutil.cpp | ||
---|---|---|
217 | How about wrapping this in a small RAII class? Without the need to run the interrupt handler we can get rid of exitDsymutil. | |
322 | Can we extract the temp-file logic into a separate function that returns a Expected<sys::fs::TempFile>? | |
324 | s/dysym/dsym/ | |
370 | My suggestion would require us to keep a vector of futures. Thinking about it, that also solves the problem of one thread calling exitDsymutil and removing temp files while another thread is still writing to them. |
tools/dsymutil/dsymutil.cpp | ||
---|---|---|
324 | What do you think about moving the vector into the RAII object? |
How about wrapping this in a small RAII class? Without the need to run the interrupt handler we can get rid of exitDsymutil.