Page MenuHomePhabricator

Remove x86 specific code from noplt.c
ClosedPublic

Authored by tmsriram on Nov 7 2017, 1:52 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tmsriram created this revision.Nov 7 2017, 1:52 PM
tmsriram added a comment.EditedNov 7 2017, 2:18 PM

More information here. This breaks non-x86 builds like PPC because:

/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/CodeGen/noplt.c:4:22: error: expected string not found in input
// CHECK-NOPLT-NEXT: declare i32 @foo

<stdin>:14:1: note: scanning from here
declare signext i32 @foo(...) #1

removing i32 from the test solves this problem.

rnk accepted this revision.Nov 7 2017, 2:31 PM

Please search for declare {{.*}}i32 @foo, and then commit. Otherwise this could match call i32 @foo or something like that.

This revision is now accepted and ready to land.Nov 7 2017, 2:31 PM
This revision was automatically updated to reflect the committed changes.