This is an archive of the discontinued LLVM Phabricator instance.

Remove x86,x86_32/64 from isValidFeatureName
ClosedPublic

Authored by erichkeane on Oct 27 2017, 11:21 AM.

Reviewers

Commits

Summary

These are not valid values for this, and are pretty
non-sensical, since LLVM doesn't understand them.

LGTM

This revision is now accepted and ready to land.Oct 27 2017, 11:26 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

lib/

Basic/

Targets/

3 lines

Show First 20 Lines • Show All 1,163 Lines • ▼ Show 20 Lines	return llvm::StringSwitch<bool>(Name)
.Case("sse2", true)		.Case("sse2", true)
.Case("sse3", true)		.Case("sse3", true)
.Case("ssse3", true)		.Case("ssse3", true)
.Case("sse4", true)		.Case("sse4", true)
.Case("sse4.1", true)		.Case("sse4.1", true)
.Case("sse4.2", true)		.Case("sse4.2", true)
.Case("sse4a", true)		.Case("sse4a", true)
.Case("tbm", true)		.Case("tbm", true)
.Case("x86", true)
.Case("x86_32", true)
.Case("x86_64", true)
.Case("xop", true)		.Case("xop", true)
.Case("xsave", true)		.Case("xsave", true)
.Case("xsavec", true)		.Case("xsavec", true)
.Case("xsaves", true)		.Case("xsaves", true)
.Case("xsaveopt", true)		.Case("xsaveopt", true)
.Default(false);		.Default(false);
}		}

▲ Show 20 Lines • Show All 481 Lines • Show Last 20 Lines